fix(popover): Null check the ref before disposing #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
- Coverage 76.64% 76.63% -0.02%
==========================================
Files 200 200
Lines 6059 6060 +1
Branches 463 464 +1
==========================================
Hits 4644 4644
- Misses 1306 1307 +1
Partials 109 109
|
|
@Gocnak thanks for the contribution! |
|
@nnixaa uhmmm anyway to npm install the master branch with this change? Or I need to wait until the next release? |
|
yep, next release only. We might be cutting a Christmas release next week with bug fixes, so stay tuned! |
|
Okay sure! (Using this for my school project - and the deadline is like next Monday 😭 ) |
|
@garyng you can connect Nebular master using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fixes #1085